Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Handle malformed comments #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Better Handle malformed comments #10

wants to merge 3 commits into from

Conversation

jbjonesjr
Copy link
Owner

@jbjonesjr jbjonesjr commented Aug 21, 2017

This PR will investigate the various problems with waking threads on schedule. Some discussion on potential problems are outlined in #8 (comment) , but will potential causes below:

  • The comment body is somehow malformed and I can't get the last snooze command even though you issued one. This is a corrupted record in terms of snooze's ability to read it. Figure out why I corrupted it, and how I should be more flexible in my reading.
  • If it's a really long thread. Too big issue threads fail #2 reminds me that I don't yet handle pagination. If it is a 100+ comment issue, and you snoozed it in the 2nd page of comments, I won't iterate/find it, and could create this situation.

closes #8

ChangeLog:

  • added test to ensure that if no snoozed issues are found, no errors are thrown
    • added logging statement to this effect
    • used property total_count vs an empty array to check for this to be more verbose, not rely on side effects on empty looping
  • added check to log to log if a snoozed thread was found with no snooze command. This should at least let us know what threads are failing

@jbjonesjr
Copy link
Owner Author

needs to resolve conflict first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'match' of undefined
1 participant